-
Notifications
You must be signed in to change notification settings - Fork 0
Task/add service defaults #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i/crucible-common-dotnet into task/add-service-defaults
src/Crucible.Common.ServiceDefaults/src/OpenTelemetry/OpenTelemetryExtensions.cs
Show resolved
Hide resolved
1. AddLogging() call added to the AddServices function 2. Adds a resolveServiceIdentity function to ensure all otel is attributed to the same service
…i/crucible-common-dotnet into task/add-service-defaults
sei-aschlackman
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new ServiceDefaults library (currently entirely OTel-related).
This is extremely WIPish, it's just easier to get the package into the container if I can publish to nuget as I iterate. I know I need to solve this problem better longterm, it's just easier to get the package source into the container env if it's on NuGet for now.
To address a couple of likely questions:
/metricsendpoint that scrapers like Prometheus can consume. I thought it might be useful in debugging as we get this up and rolling, to make sure we're writing the metrics we want to. I see this being off most of the time in practice except for specialized cases, or to check stuff out in dev.I expect this will change/grow a lot even over the course of my initial implementation, but wanted to get something in there. Very much welcome your thoughts.